Validate filter URIs used for registering listeners #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved logic for validating authority names in URIs to be more strict and included validation of pattern URIs in checks for registering listeners.
sophokles73
force-pushed
the
improve_authority_name_validation
branch
from
f9487df to
24af15d
Compare
The lychee tool currently does not support proper handling of AsciiDoc files. Therefore, we exclude them from link checks to avoid false positives.
AnotherDaniel
approved these changes
Sep 25, 2025
Contributor
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
LGTM - a bit torn whether it'd be convenient or counterproductive to have Uuri constructors automatically lower-case any authority strings... but probably counterproductive, as we want people to be aware that they're using invalid names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved logic for validating authority names in URIs to be more strict
and included validation of pattern URIs in checks for registering
listeners.