HttpClient: introduce a connection timeout in ProxyOptions#5650
Merged
tsegismont merged 2 commits intoeclipse-vertx:masterfrom Jul 21, 2025
Merged
HttpClient: introduce a connection timeout in ProxyOptions#5650tsegismont merged 2 commits intoeclipse-vertx:masterfrom
tsegismont merged 2 commits intoeclipse-vertx:masterfrom
Conversation
vietj
reviewed
Jul 17, 2025
Member
Author
|
@vietj PTAL |
See eclipse-vertx#5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
vietj
approved these changes
Jul 21, 2025
tsegismont
added a commit
to tsegismont/vert.x
that referenced
this pull request
Jul 21, 2025
…ertx#5650) * HttpClient: introduce a connection timeout in ProxyOptions See eclipse-vertx#5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Use java.time.Duration for ProxyOptions connection timeout Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vert.x
that referenced
this pull request
Jul 21, 2025
Backported from eclipse-vertx#5650 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vert.x
that referenced
this pull request
Jul 21, 2025
…ertx#5650) * HttpClient: introduce a connection timeout in ProxyOptions See eclipse-vertx#5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Use java.time.Duration for ProxyOptions connection timeout Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vert.x
that referenced
this pull request
Jul 21, 2025
…ertx#5650) * HttpClient: introduce a connection timeout in ProxyOptions See eclipse-vertx#5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Use java.time.Duration for ProxyOptions connection timeout Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jul 24, 2025
…5654) * HttpClient: introduce a connection timeout in ProxyOptions See #5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. * Use java.time.Duration for ProxyOptions connection timeout --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jul 24, 2025
…5655) * HttpClient: introduce a connection timeout in ProxyOptions See #5634 In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully. Successfully means slightly different things, depending on the proxy type: - for an HTTP proxy, it means the LastHttpContent message of the proxy response to the CONNECT request has been received, and the status code is 200 - for a SOCKS proxy, it means the SOCKS handshake ended with the SUCCESS status. Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout. * Use java.time.Duration for ProxyOptions connection timeout --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5634
In Netty's ProxyHandler, a default timeout of 10 seconds is set for the connection to be established successfully.
Successfully means slightly different things, depending on the proxy type:
Sometimes, users have to deal with external servers behind their proxy that they don't control and that are slow to establish the connection. In such cases, it is required to increase the ProxyHandler timeout.