Repair and execute the Swing Databinding tests #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
fix-swing-databinding-tests
branch
from
c1e9591 to
0504ff5
Compare
ptziegler
commented
Jun 5, 2025
| " }", | ||
| " }", | ||
| "}"}); | ||
| m_waitForAutoBuild = true; |
Contributor
Author
There was a problem hiding this comment.
The ClassNotFoundException: test.Test$MyBean is likely an indicator that the snippet hasn't been compiled by the time this method returns. For small snippets this is never really a problem but for bigger stuff like this, we need to explicitly wait.
ptziegler
force-pushed
the
fix-swing-databinding-tests
branch
from
0504ff5 to
5b287fa
Compare
The databinding tests have been disabled because they rely on the (withdrawn[1]) JSR295 specification. Given that this specification is also supported by e.g. Netbeans and the JFormDesigner, it seems too early to remove it completely. Given that this artifact is only used for testing, the jar is embedded directly into the test bundle so that it doesn't need to be added to Orbit. With the changes done in 96abbd1, an IllegalArgumentException would be thrown because the array of properties may contain duplicates. This has been revealed by those tests and fixed accordingly. [1] https://jcp.org/en/jsr/detail?id=295
ptziegler
force-pushed
the
fix-swing-databinding-tests
branch
from
5b287fa to
07e8ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The databinding tests have been disabled because they rely on the (withdrawn[1]) JSR295 specification. Given that this specification is also supported by e.g. Netbeans and the JFormDesigner, it seems too early to remove it completely.
Given that this artifact is only used for testing, the jar is embedded directly into the test bundle so that it doesn't need to be added to Orbit.
With the changes done in 96abbd1, an IllegalArgumentException would be thrown because the array of properties may contain duplicates. This has been revealed by those tests and fixed accordingly.
[1] https://jcp.org/en/jsr/detail?id=295