Adapt tests to changed copy-paste functionality #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
fix-copy-paste-tests
branch
from
adc015b to
7563550
Compare
With c7961f3, the copy-paste operation remembers the variable name, but the tests were never updated to this new functionality. Furthermore, this also fixes a regression where an IllegalArgumentException would be thrown if the VariableSupport of the current JavaInfo doesn't override the getName() method.
ptziegler
force-pushed
the
fix-copy-paste-tests
branch
from
7563550 to
3a69d06
Compare
ptziegler
merged commit e1f25a0
into
eclipse-windowbuilder:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With c7961f3, the copy-paste operation remembers the variable name, but the tests were never updated to this new functionality.
Furthermore, this also fixes a regression where an IllegalArgumentException would be thrown if the VariableSupport of the current JavaInfo doesn't override the getName() method.