[Draw2D] Harmonize tool-tip handling of WindowBuilder figures #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
draw2d-tooltip-handling
branch
3 times, most recently
from
e545a96 to
08857c7
Compare
By wrapping the tool-tip string in a Label, it is possible to use the setToolTip() method specified by the IFigure interface, thus avoiding an additional setToolTipText() method. This Label then needs to be unwrapped in our EventManager, as figures are not yet supported here, until the manager has been harmonized with the SWTEventDispatcher. The tool-tip handling has also been improved so that it is only shown for non-empty strings.
ptziegler
force-pushed
the
draw2d-tooltip-handling
branch
from
08857c7 to
aba95d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By wrapping the tool-tip string in a Label, it is possible to use the setToolTip() method specified by the IFigure interface, thus avoiding an additional setToolTipText() method.
This Label then needs to be unwrapped in our EventManager, as figures are not yet supported here, until the manager has been harmonized with the SWTEventDispatcher.
The tool-tip handling has also been improved so that it is only shown for non-empty strings.