[Draw2D] Correct mouse coordinates in GEF event dispatcher #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
draw2d-tooltip-handling
branch
3 times, most recently
from
3375521 to
341b209
Compare
The MouseEvent created by the sendEvent() method already converts the (x,y) coordinates of the canvas to figure-local coordinates. With the current implementation, this means this conversion is done twice.
ptziegler
force-pushed
the
draw2d-tooltip-handling
branch
from
341b209 to
57d8726
Compare
ptziegler
merged commit 8587cb9
into
eclipse-windowbuilder:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MouseEvent created by the sendEvent() method already converts the (x,y) coordinates of the canvas to figure-local coordinates. With the current implementation, this means this conversion is done twice.