[GEF] RootEditPart should implement the LayerManager interface #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layer should be accessed from the RootEditPart, not the EditPartViewer. This requires the root edit part to implement the LayerManager interface and to use the LayerManager.ID as model, to become visible to the LayerManager.Helper class.
ptziegler
force-pushed
the
gef-layer-manager
branch
from
2027996 to
7196bc7
Compare
ptziegler
changed the title
ptziegler
merged commit cb51a82
into
eclipse-windowbuilder:master
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layer should be accessed from the RootEditPart, not the EditPartViewer. This requires the root edit part to implement the LayerManager interface and to use the LayerManager.ID as model, to become visible to the LayerManager.Helper class.