[GEF] TargetingTool#getExclusionSet() should return a IFigure's #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adapts the return type of the getExclusionSet() method from a collection of EditParts to a collection of IFigures, to match the signature of the GEF tool As a result, the findTargetEditPart() method needs to be adapted to now accept this collection of IFigures. Note that this causes issues with the TreeViewer, as it is based on TreeItems, not IFigures. To solve this, the exclusion set has been moved and is now a part of the Conditional.
ptziegler
force-pushed
the
gef-exclusion-set
branch
from
a461fcb to
2152829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adapts the return type of the getExclusionSet() method from a collection of EditParts to a collection of IFigures, to match the signature of the GEF tool
As a result, the findTargetEditPart() method needs to be adapted to now accept this collection of IFigures.
Note that this causes issues with the TreeViewer, as it is based on TreeItems, not IFigures. To solve this, the exclusion set has been moved and is now a part of the Conditional.