[GEF] Calculate target handle using findFigureAt() #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Extracted from #1130 because both changes are quite tricky. |
ptziegler
force-pushed
the
gef-target-handle
branch
from
2581c2e to
1f3b5d5
Compare
ptziegler
force-pushed
the
gef-target-handle
branch
from
1f3b5d5 to
0de0d47
Compare
Contributor
Author
|
It was a little bit of a challenge to adapt the tests to the way the Furthermore, it is only possible to select figures within the visible area, which is a known limitation of GEF that is also affecting other testing tools. To get around this, our tester has to always scroll the viewer to make sure the figure is visible. |
This replaces the TargetFigureFindVisitor used in the findTargetHandle() method with call to findFigureAt(), which is provided by Draw2D. A custom filter is used to restrict the search to only accept Handles and to only look in the specified layer.
ptziegler
force-pushed
the
gef-target-handle
branch
from
0de0d47 to
7fcb3ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the TargetFigureFindVisitor used in the findTargetHandle() method with call to findFigureAt(), which is provided by Draw2D. A custom filter is used to restrict the search to only accept Handles and to only look in the specified layer.