[GEF] Rename getLocation() and getStartLocation() in Tool #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getLocation() and getStartLocation() defined by the GEF class describe the relative location, not the absolute locations. To avoid any confusion, our methods should be called getAbsoluteLocation() and getAbsoluteStartLocation(). Note: In the future we should also migrate to relative coordinates.
ptziegler
force-pushed
the
gef-tool-location
branch
from
fc4d39a to
f93ec93
Compare
ptziegler
merged commit 73d9c65
into
eclipse-windowbuilder:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getLocation() and getStartLocation() defined by the GEF class describe the relative location, not the absolute locations. To avoid any confusion, our methods should be called getAbsoluteLocation() and getAbsoluteStartLocation().
Note: In the future we should also migrate to relative coordinates.