Reactivate BindingsTest and adapt Bindings classes to expected behavior #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a new method is added to the IMethodBinding, IPackageBinding or the ITypeBinding, the Designer implementation must be either implemented properly or throw an IllegalArgumentException(). Instead, those methods have been implemented by returning a default value, which brings the risk of diverging from the value of the underlying binding and thus leading to inconsistent behavior. The affected methods have been adapted to take this expected behavior into consideration and for trivial cases, been correctly implemented. Affected commits: - cf88ae1 - 6912838 - 6648a1c - a6af2a2 - 9e52223 - 2849290
Contributor
Author
|
Extracted into a separate commit due to actual code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a new method is added to the IMethodBinding, IPackageBinding or the ITypeBinding, the Designer implementation must be either implemented properly or throw an IllegalArgumentException().
Instead, those methods have been implemented by returning a default value, which brings the risk of diverging from the value of the underlying binding and thus leading to inconsistent behavior.
The affected methods have been adapted to take this expected behavior into consideration and for trivial cases, been correctly implemented.
Affected commits: