Repair and execute PropertyTableTooltipTest #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Separated from #1109 due to code changes. |
ptziegler
force-pushed
the
fix-property-table-tests
branch
3 times, most recently
from
5d4999e to
3eca2b5
Compare
ptziegler
force-pushed
the
fix-property-table-tests
branch
2 times, most recently
from
a9c5cba to
0bb9a23
Compare
ptziegler
commented
Jul 19, 2025
Comment on lines
49
to
55
| // support clicking outside the property table | ||
| FillLayout layout = new FillLayout(); | ||
| layout.marginHeight = DEFAULT_MARGIN; | ||
| layout.marginWidth = DEFAULT_MARGIN; | ||
| // | ||
| m_shell = new Shell(SWT.NO_TRIM); | ||
| m_shell.setLayout(layout); |
Contributor
Author
There was a problem hiding this comment.
A lot of tests tend to fail on one operating system, but not the other. This is because the window decorations differ and therefore all coordinates have a different offset.
Contributor
Author
|
An example of what the tool-tip looks like: 
I've moved the definition of this fallback tooltip to the PropertyFigure so that the whole logic is contained within the |
ptziegler
force-pushed
the
fix-property-table-tests
branch
from
0bb9a23 to
b5d7beb
Compare
The tool-tip tests for the property table are no longer disabled and are therefore executed as part of the automatic tests. During the reactivation, it was discovered that one specific behavior no longer occurs; If the property text is longer than the column, a tool-tip should be shown, containing the entire text (Similar to how an SWT table behaves).
ptziegler
force-pushed
the
fix-property-table-tests
branch
from
b5d7beb to
15d7b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool-tip tests for the property table are no longer disabled and are therefore executed as part of the automatic tests.
During the reactivation, it was discovered that one specific behavior no longer occurs; If the property text is longer than the column, a tool-tip should be shown, containing the entire text (Similar to how an SWT table behaves).