Skip to content

Replace deprecated ViewerSorter with ViewerComparator #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Replace deprecated ViewerSorter with ViewerComparator #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ipse.wb.rcp/src/org/eclipse/wb/internal/rcp/model/jface/DialogButtonIdPropertyEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011 Google, Inc.
* Copyright (c) 2011, 2025 Google, Inc. and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License 2.0 which is available at
Expand Down Expand Up @@ -58,7 +58,7 @@
import org.eclipse.jface.viewers.LabelProvider;
import org.eclipse.jface.viewers.TableViewer;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.jface.viewers.ViewerSorter;
import org.eclipse.jface.viewers.ViewerComparator;
import org.eclipse.jface.window.Window;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.SelectionAdapter;
Expand Down Expand Up @@ -302,7 +302,7 @@ public void widgetSelected(SelectionEvent e) {
TableFactory.modify(table).newColumn().widthC(47).text(
ModelMessages.DialogButtonIdPropertyEditor_columnId);
}
m_viewer.setSorter(new IdSorter());
m_viewer.setComparator(new IdComparator());
m_viewer.setLabelProvider(new IdLabelProvider());
m_viewer.setContentProvider(new ArrayContentProvider());
m_viewer.addDoubleClickListener(new IDoubleClickListener() {
Expand Down Expand Up @@ -429,7 +429,7 @@ public void run() throws Exception {
// Viewer elements
//
////////////////////////////////////////////////////////////////////////////
private class IdSorter extends ViewerSorter {
private class IdComparator extends ViewerComparator {
@Override
public int compare(Viewer viewer, Object e1, Object e2) {
IdLabelProvider labelProvider = (IdLabelProvider) m_viewer.getLabelProvider();
Expand Down
Loading