Refactor Box edit-parts to use plain Draw2D Figures #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no benefit in using our "Designer" figures, outside of dealing with relative instead of absolute coordinates. This adapts the following edit parts: - Horizontal Strut - Vertical Strut - Horizontal Glue - Vertical Glue - Rigid Area - Glue
Contributor
Author
|
ptziegler
commented
Jul 16, 2025
Comment on lines
+81
to
+82
| int y = 0; | ||
| while (y < r.height) { |
Contributor
Author
There was a problem hiding this comment.
I don't know why the coordinates are calculated like this for the vertical, but not the horizontal edit part. But this calculation is factually wrong.
The graphics instance is translated so that (0, 0) is the top left corner of this figure. So y = r.y paints outside the client area unless y = 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no benefit in using our "Designer" figures, outside of dealing with relative instead of absolute coordinates.
This adapts the following edit parts: