Migrate TextFeedback to use plain Draw2D labels #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ptziegler
force-pushed
the
text-feedback-figure
branch
from
a540bec to
2d6e56a
Compare
This adapts the VerticalLabel to extend the Draw2D Label class, rather than our copy, in order to clean up the usage in the TextFeedback class. There is no benefit to using our classes over the upstream classes and migrating makes it possible to remove them at a later stage.
Contributor
Author
|
The whole step of first painting the vertical text onto an image and then the image onto the canvas can be skipped entirely, simply by rotating the Graphics object. 🎉 |
ptziegler
force-pushed
the
text-feedback-figure
branch
from
2d6e56a to
63a3e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the VerticalLabel to extend the Draw2D Label class, rather than our copy, in order to clean up the usage in the TextFeedback class.
There is no benefit to using our classes over the upstream classes and migrating makes it possible to remove them at a later stage.