Improve access to JDT preference store #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the reflective access to the JDT UI preference store with a call to `PreferenceConstants.getPreferenceStore()`. In addition, the PreferenceAdapter is marked as deprecated, to resolve the warnings produced by referencing the deprecated Eclipse Preferences. The class sadly can't be removed, because JDT Core doesn't have a public accessor for its preference store and because this deprecated class is required for the JavaTextTools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the reflective access to the JDT UI preference store with a call to
PreferenceConstants.getPreferenceStore().In addition, the PreferenceAdapter is marked as deprecated, to resolve the warnings produced by referencing the deprecated Eclipse Preferences. The class sadly can't be removed, because JDT Core doesn't have a public accessor for its preference store and because this deprecated class is required for the JavaTextTools.