Skip to content

Repair and execute Editor tests #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

Repair and execute Editor tests #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ....tests/src/org/eclipse/wb/tests/designer/editor/JavaPropertiesToolBarContributorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.eclipse.swtbot.swt.finder.SWTBot;
import org.eclipse.swtbot.swt.finder.widgets.SWTBotToolbarButton;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand Down Expand Up @@ -91,7 +90,6 @@ public Test() {
/**
* Test for "Local to field" action.
*/
@Disabled
@Test
public void test_convertLocalToField() throws Exception {
openContainer("""
Expand Down
4 changes: 1 addition & 3 deletions org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/editor/SplitModeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.eclipse.jface.preference.IPreferenceStore;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.awt.Component;
Expand Down Expand Up @@ -63,7 +62,6 @@ public void _test_exit() throws Exception {
//
////////////////////////////////////////////////////////////////////////////
@Test
@Disabled
public void test_reparse_afterDelay() throws Exception {
IPreferenceStore preferences = DesignerPlugin.getPreferences();
preferences.setValue(
Expand All @@ -81,6 +79,7 @@ public Test() {
check_isEnabled(true);
// set focus to Source, as if user does this
{
m_designerEditor.getSite().getShell().forceActive();
MultiMode multiMode = (MultiMode) m_designerEditor.getMultiMode();
multiMode.getSourcePage().setFocus();
}
Expand All @@ -94,7 +93,6 @@ public Test() {
check_isEnabled(true);
// wait for re-parse
waitEventLoop(1000);
fetchContentFields();
check_isEnabled(false);
}

Expand Down
5 changes: 2 additions & 3 deletions org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/editor/UndoManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
import org.apache.commons.lang3.function.FailableConsumer;
import org.apache.commons.lang3.function.FailableRunnable;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;
Expand Down Expand Up @@ -274,7 +273,6 @@ public Test() {
/**
* Sometimes expansion paths are remembered for wrong dump, so this causes later exception.
*/
@Disabled
@Test
public void test_expandRemembered_bug_0() throws Exception {
ContainerInfo frame = openContainer("""
Expand Down Expand Up @@ -311,6 +309,8 @@ public Test() {
openSourcePage();
// organize imports
actionBars.getGlobalActionHandler(JdtActionConstants.ORGANIZE_IMPORTS).run();
// wait for "Organize Imports" job
waitEventLoop(50);
assertEquals(
getSourceDQ(
"package test;",
Expand Down Expand Up @@ -597,7 +597,6 @@ public Test() {
* exceptions.
*/
@DisposeProjectAfter
@Disabled
@Test
public void test_showDesign_rename() throws Exception {
openContainer("""
Expand Down
2 changes: 0 additions & 2 deletions org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/editor/actions/CutActionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import org.eclipse.jface.action.IAction;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand Down Expand Up @@ -72,7 +71,6 @@ public Test() {
/**
* Test for cut/paste single component.
*/
@Disabled
@Test
public void test_cutSingle() throws Exception {
ContainerInfo panel = openContainer("""
Expand Down
3 changes: 1 addition & 2 deletions org.eclipse.wb.tests/src/org/eclipse/wb/tests/designer/editor/actions/SwitchActionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import org.eclipse.wb.internal.core.editor.multi.MultiMode;
import org.eclipse.wb.tests.designer.swing.SwingGefTest;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand All @@ -33,7 +32,6 @@ public class SwitchActionTest extends SwingGefTest {
/**
* Test for switching to source and back to design.
*/
@Disabled
@Test
public void test_1() throws Exception {
openContainer("""
Expand All @@ -42,6 +40,7 @@ public class Test extends JPanel {
public Test() {
}
}""");
m_designerEditor.getSite().getShell().forceActive();
MultiMode multiMode = (MultiMode) m_designerEditor.getMultiMode();
// prepare action
SwitchAction switchAction;
Expand Down
Loading