Disable BurningWave initialization by default #1305 #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurningWave is using Unsafe to break the module system introduced with Java 9, in order to allow WindowBuilder to access the internal Swing fields and methods. The implementation has already been adapted in the past so that this dependency can be disabled, by setting the "wbp.burningwave.enabled" system property to "false". But for the sake of backwards compatibility, this property was initialized with "true". With this change, this property now needs to be explicitly enabled. Closes #1305
ptziegler
changed the title
Contributor
Author
|
Merging for the RC2, as a potential SEGFAULT is quite nasty. |
Contributor
|
I'm sitting at the IDE Working Group Steering Committee today with @iloveeclipse as an invited guest discussing how super impressive and gratifying it is to see your responsiveness on this issue. Kudos! 🏅 ❣️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.