Skip to content

Add API Analysis nature to all plugins#1399

Merged
ptziegler merged 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:baseline-check-pt1
Mar 24, 2026
Merged

Add API Analysis nature to all plugins#1399
ptziegler merged 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:baseline-check-pt1

Conversation

@ptziegler
Copy link
Copy Markdown
Contributor

@ptziegler ptziegler commented Mar 23, 2026

This adds the "API Analysis Nature" to all WindowBuilder projects, adds the 2026-03 baseline and converts all JavaDoc annotations to proper PDE annotations.

@ptziegler ptziegler added this to the 1.24.0 milestone Mar 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

Test Results

 2 720 files  ±0   2 720 suites  ±0   10h 54m 58s ⏱️ + 5m 40s
 7 018 tests ±0   6 960 ✅ ±0   58 💤 ±0  0 ❌ ±0 
28 072 runs  ±0  27 830 ✅ ±0  242 💤 ±0  0 ❌ ±0 

Results for commit 080737c. ± Comparison against base commit 9154f15.

♻️ This comment has been updated with latest results.

@ptziegler ptziegler force-pushed the baseline-check-pt1 branch from 8311aa4 to 668e790 Compare March 23, 2026 21:40
@ptziegler ptziegler changed the title This adds the "API Analysis Nature" to all WindowBuilder projects, adds Add API Analysis nature to all plugins Mar 23, 2026
@ptziegler
Copy link
Copy Markdown
Contributor Author

Error:  D:\a\windowbuilder\windowbuilder\org.eclipse.wb.core\src\org\eclipse\wb\internal\core\views\StructureView.java: 
Error:  	/*******************************************************************************
Error:  	^
Error:  The type org.eclipse.pde.api.tools.annotations.NoOverride cannot be resolved. It is indirectly referenced from required type org.eclipse.draw2d.Figure
Error: [ERROR] 1 problem (1 error)

Where does the reference to the Draw2D Figure even come from? And shouldn't the PDE annotations be added automatically to the classpath? And why does it only show up when using the API Analysis nature?

@ptziegler
Copy link
Copy Markdown
Contributor Author

ptziegler commented Mar 23, 2026

I think the issue is the result of different versions of org.eclipse.pde.api.tools.annotations being in the classpath. The latest release on Maven Central is 1.4.0, while the 2026-06 target platform provides 1.4.100.v20260306-2228. Even if they have the same fully-qualified name, they are treated as different types.

This also explains why this issue only shows up for projects where I also use the PDE annotations.

@ptziegler ptziegler force-pushed the baseline-check-pt1 branch from 668e790 to 3708634 Compare March 23, 2026 22:08
@ptziegler
Copy link
Copy Markdown
Contributor Author

I've removed the PDE annotations in WindowBuilder again ad at least locally, the build is successful. More evidence that this is a classloader problem.

This adds the "API Analysis Nature" to all WindowBuilder projects and
adds the 2026-03 baseline to the workspace.
@ptziegler ptziegler force-pushed the baseline-check-pt1 branch from 3708634 to 080737c Compare March 24, 2026 17:33
@ptziegler ptziegler merged commit 80df795 into eclipse-windowbuilder:master Mar 24, 2026
9 checks passed
@ptziegler ptziegler deleted the baseline-check-pt1 branch March 24, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant