[GEF] Harmonize EditPolicy with upstream class#1409
Merged
ptziegler merged 1 commit intoMar 26, 2026
Conversation
This split up our "Design" edit policy into two components: - Everything related to the activation and deactivation of an edit policy is moved to the "DesignEditPolicy" subclass, which is extended by the "GraphicalEditPolicy". - Everything related to request-handling is moved to the "IRequestEditPolicy". This interface is implemented both by the "GraphicalEditPolicy", as well as all non-graphical edit policies that implement the "performRequest(...)" methods. The old EditPolicy class and all public methods referencing it have been marked as for-removal and are no longer referenced internally (expect by the "DesignEditPolicy" for backwards compatibility.
ptziegler
force-pushed
the
gef-edit-policy
branch
from
4bb712b to
edb5e7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This split up our "Design" edit policy into two components:
Everything related to the activation and deactivation of an edit policy is moved to the "DesignEditPolicy" subclass, which is extended by the "GraphicalEditPolicy".
Everything related to request-handling is moved to the "IRequestEditPolicy". This interface is implemented both by the "GraphicalEditPolicy", as well as all non-graphical edit policies that implement the "performRequest(...)" methods.
The old EditPolicy class and all public methods referencing it have been marked as for-removal and are no longer referenced internally (expect by the "DesignEditPolicy" for backwards compatibility.