Reactivate TableTest.test_TableColumn#1450
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Apr 18, 2026
Merged
Reactivate TableTest.test_TableColumn#1450ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
ptziegler
force-pushed
the
swt-table-test
branch
from
b21fef4 to
e5e0a9d
Compare
Test Results 2 720 files ±0 2 720 suites ±0 11h 9m 43s ⏱️ -59s For more details on these failures, see this check. Results for commit 5c75f68. ± Comparison against base commit ccda5c8. ♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
swt-table-test
branch
11 times, most recently
from
fd655e5 to
209925b
Compare
The test fails on Linux when running with Xvnc. Underlying reason seems to be that tree columns behave differently on Linux than on Windows. When `setHeaderVisible(true)` is called and the shell is opened, the table column will take up the entire width of the shell, ignoring the values passed to `tableColumn.setWidth(...)`. On Linux this corresponds to the methods: - gtk_tree_view_column_get_fixed_width - gtk_tree_view_column_get_width Within this test, the second method is called because the shell is made visible for a short period while taking the screenshot, which internally causes `gtk_size_allocate` to be called. Given that this issue doesn't appear when executing the test locally, this seems to be a problem with the virtual desktop. To avoid this problem, the test is no longer done with a shell, but a plain composite.
ptziegler
force-pushed
the
swt-table-test
branch
from
209925b to
5c75f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactivate TableTest.test_TableColumn
The test fails on Linux when running with Xvnc. Underlying reason seems to be that tree columns behave differently on Linux than on Windows.
When
setHeaderVisible(true)is called and the shell is opened, the table column will take up the entire width of the shell, ignoring the values passed totableColumn.setWidth(...). On Linux this corresponds to the methods:Within this test, the second method is called because the shell is made visible for a short period while taking the screenshot, which internally causes
gtk_size_allocateto be called. Given that this issue doesn't appear when executing the test locally, this seems to be a problem with the virtual desktop.To avoid this problem, the test is no longer done with a shell, but a plain composite.