Reduce code duplication in LayoutNameSupport#1464
Merged
ptziegler merged 1 commit intoApr 26, 2026
Merged
Conversation
The `templateLayoutName` preference is the same between Swing and SWT, so the preference constants can be moved to the Core plugin. Due to split packages, this then means that the `IPreferenceConstants` in the Java plugin has to be removed, as it conflicts with the class in the Core plugin. But which doesn't matter, as they are otherwise identical. This then means that the `getTemplate()` can be moved up to the parent class. Only the list of available templates needs to be known, which is declared via the new, abstract `getTemplates()` method. Additionally, the `getValueMap()` method can be partially moved to the base class, because the `layoutAcronym` and `layoutClassName` styles are shared. The method is overridden to add Swing and SWT-specific layouts.
Test Results 2 720 files ±0 2 720 suites ±0 11h 22m 7s ⏱️ + 59m 4s For more details on these errors, see this check. Results for commit 08d0910. ± Comparison against base commit 9e303e6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
templateLayoutNamepreference is the same between Swing and SWT, so the preference constants can be moved to the Core plugin. Due to split packages, this then means that theIPreferenceConstantsin the Java plugin has to be removed, as it conflicts with the class in the Core plugin. But which doesn't matter, as they are otherwise identical.This then means that the
getTemplate()can be moved up to the parent class. Only the list of available templates needs to be known, which is declared via the new, abstractgetTemplates()method.Additionally, the
getValueMap()method can be partially moved to the base class, because thelayoutAcronymandlayoutClassNamestyles are shared. The method is overridden to add Swing and SWT-specific layouts.