[Draw2D] SemiTransparentFigure should extend Draw2D figure#1470
Merged
ptziegler merged 1 commit intoApr 26, 2026
Merged
Conversation
This adapts the `SemiTransparentFigure` and `TopResizeFigure` to extend a plain Draw2D `Figure` directly. The references have been adapted to also use the Draw2D `LineBorder` to avoid the issues when translating between absolute and local coordinates. The `AbstractPositionFeedback` and `GhostPositionFeedback` have been marked as "for removal" and will be internalized after the 2028-06 release. The `SemiTransparentFigure` has also been marked for removal and will be removed alltogether.
a461bbc to
ba21573
Compare
Test Results 2 720 files ±0 2 720 suites ±0 10h 38m 15s ⏱️ - 33m 2s For more details on these errors, see this check. Results for commit ba21573. ± Comparison against base commit 78dff98. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts the
SemiTransparentFigureandTopResizeFigureto extend a plain Draw2DFiguredirectly. The references have been adapted to also use the Draw2DLineBorderto avoid the issues when translating between absolute and local coordinates.The
AbstractPositionFeedbackandGhostPositionFeedbackhave been marked as "for removal" and will be internalized after the 2028-06 release. TheSemiTransparentFigurehas also been marked for removal and will be removed alltogether.