Fix potential NPE when refreshing MenuObjectEditPart#1487
Merged
ptziegler merged 1 commit intoApr 30, 2026
Merged
Conversation
By virtue of being executed asynchronously, the refresh operation within the `MenuObjectEditPart` might throw a `NullPointerException` when executed after the viewer has been disposed. Additionally, it may also throw an exception when the edit parts that are being refresh no longer exists, which might happen if they are former children of a different `MenuObjectEditPart` which was refreshed earlier.
Test Results 2 720 files ±0 2 720 suites ±0 11h 6m 3s ⏱️ + 1h 0m 45s For more details on these failures, see this check. Results for commit 5ebb5c8. ± Comparison against base commit a31a05a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By virtue of being executed asynchronously, the refresh operation within the
MenuObjectEditPartmight throw aNullPointerExceptionwhen executed after the viewer has been disposed. Additionally, it may also throw an exception when the edit parts that are being refresh no longer exists, which might happen if they are former children of a differentMenuObjectEditPartwhich was refreshed earlier.