Don't bind update of ObjectEditPart to SWT.PaintItem event#1490
Merged
ptziegler merged 1 commit intoMay 1, 2026
Conversation
The `PaintItem` event might be fired while refreshing the `JavaInfo` model, i.e. after the old model has been disposed, but before the new model has been fully created. In such a situation, the update will throw a `WIDGET_IS_DISPOSED` exception, because the edit-part is still referencing the (now disposed) tree widget associated with the old model. Note that this initial implementation was likely done as a performance optimization, to make sure that the visualization of the edit part is only calculated if the tree item is actually rendered. Contributes to eclipse-windowbuilder#1485
Test Results 2 720 files ±0 2 720 suites ±0 11h 10m 9s ⏱️ + 42m 35s For more details on these failures, see this check. Results for commit bbe7fd2. ± Comparison against base commit 8b61bb4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PaintItemevent might be fired while refreshing theJavaInfomodel, i.e. after the old model has been disposed, but before the new model has been fully created. In such a situation, the update will throw aWIDGET_IS_DISPOSEDexception, because the edit-part is still referencing the (now disposed) tree widget associated with the old model.Note that this initial implementation was likely done as a performance optimization, to make sure that the visualization of the edit part is only calculated if the tree item is actually rendered.
Contributes to
#1485