Skip to content

[GEF] Fix: Repaint operation has to consider local coordinates#562

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:gef-local-coordinates
Aug 29, 2023
Merged

[GEF] Fix: Repaint operation has to consider local coordinates#562
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:gef-local-coordinates

Conversation

@ptziegler
Copy link
Copy Markdown
Contributor

The coordinates of the WindowBuilder figures are placed relative to the top-left corner of their parent. The useLocalCoordinates() method has to return true, otherwise the repaint operation will threat those as absolute coordinates and update the wrong area.

The coordinates of the WindowBuilder figures are placed relative to the
top-left corner of their parent. The useLocalCoordinates() method has to
return true, otherwise the repaint operation will threat those as
absolute coordinates and update the wrong area.
@github-actions
Copy link
Copy Markdown

Unit Test Results

         2 files           2 suites   1h 12m 58s ⏱️
  7 032 tests   6 838 ✔️ 194 💤 0
14 064 runs  13 676 ✔️ 388 💤 0

Results for commit fb00947.

@merks
Copy link
Copy Markdown
Contributor

merks commented Aug 29, 2023

FYI. RC1 is due tomorrow.

@ptziegler
Copy link
Copy Markdown
Contributor Author

Oh, crap... I was convinced the RC1 was due next week... Thanks for reminding me.

@ptziegler ptziegler merged commit 17f2f95 into eclipse-windowbuilder:master Aug 29, 2023
@merks
Copy link
Copy Markdown
Contributor

merks commented Aug 29, 2023

RC2 is next week and that is that last contribution.

@ptziegler
Copy link
Copy Markdown
Contributor Author

So it went down to a one-week internal. Got it.

@ptziegler ptziegler deleted the gef-local-coordinates branch October 21, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants