Skip to content

Fix: Unable to open design page for view page#563

Merged
ptziegler merged 2 commits intoeclipse-windowbuilder:masterfrom
ptziegler:issue461
Sep 5, 2023
Merged

Fix: Unable to open design page for view page#563
ptziegler merged 2 commits intoeclipse-windowbuilder:masterfrom
ptziegler:issue461

Conversation

@ptziegler
Copy link
Copy Markdown
Contributor

An exception is thrown when calling
getSite().getActionBars().getMenuManager(). When trying to resolve those
methods, we internally touch on methods hidden by encapsulation. This
then throws an unhandled InaccessibleObjectException exception.

Note: The problematic class is MethodHandles.Lookup in the Proxy class.

The Swing templates have been adapted to also generated the default
serialVersionUID in order to resolve the corresponding warning.

Test cases have been added to check, whether the design page can be
openened for all templates contributed via the New wizard.

This also resolves the missing serialVersionUID warning when creating
a new Swing widget.

When creating a new Swing widget, the Eclipse compiler creates a warning
due to a missing serialVersionUID. For the sake of simplicity this
variable is generated and initialized with a default value.
@ptziegler
Copy link
Copy Markdown
Contributor Author

When using the IToolBarManager, the captured image seems to be empty :/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2023

Unit Test Results

         2 files           2 suites   1h 16m 10s ⏱️
  7 056 tests   6 862 ✔️ 194 💤 0
14 112 runs  13 724 ✔️ 388 💤 0

Results for commit a94842c.

♻️ This comment has been updated with latest results.

An exception is thrown when calling
getSite().getActionBars().getMenuManager(). When trying to resolve those
methods, we internally touch on methods hidden by encapsulation. This
then throws an unhandled InaccessibleObjectException exception.

Note: The problematic class is MethodHandles.Lookup in the Proxy class.

The Swing templates have been adapted to also generated the default
serialVersionUID in order to resolve the corresponding warning.

Test cases have been added to check, whether the design page can be
openened for all templates contributed via the New wizard.
@ptziegler ptziegler linked an issue Sep 4, 2023 that may be closed by this pull request
@ptziegler ptziegler merged commit 96d5cf1 into eclipse-windowbuilder:master Sep 5, 2023
@ptziegler ptziegler deleted the issue461 branch September 5, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViewPart template fails with NullPointerException

1 participant