Merged
Conversation
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ies' into zbobr_fix-44-stabilize-accept-replies
|
PR missing one of the required labels: {'internal', 'documentation', 'breaking-change', 'dependencies', 'api-sync', 'ci', 'bug', 'new feature', 'enhancement'} |
9 tasks
Update zenoh-c from a3071a12 to a3bf806e which includes the "stabilize accept replies (#1212)" change needed for the zenoh-cpp accept_replies stabilization task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update zenoh-c from a3071a12 to a3bf806e which includes the "stabilize accept replies (#1212)" change needed for the zenoh-cpp accept_replies stabilization task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ies' into zbobr_fix-44-stabilize-accept-replies
milyin
commented
Mar 10, 2026
milyin
commented
Mar 10, 2026
milyin
commented
Mar 10, 2026
milyin
commented
Mar 10, 2026
DenisBiryukov91
approved these changes
Mar 10, 2026
Contributor
|
Still missing accept_replies() getter for Query |
Include the new zc_query_accepts_replies() C API function from "add accept replies accessor to query (#1215)". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Include the new zc_query_accepts_replies() C API function from "add accept replies accessor to query (#1215)". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a new method to the C++ Query class that wraps zc_query_accepts_replies(), returning ReplyKeyExpr to indicate which replies are accepted by the query originator. Guarded with #if defined(ZENOHCXX_ZENOHC) since it's zenoh-c only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a new method to the C++ Query class that wraps zc_query_accepts_replies(), returning ReplyKeyExpr to indicate which replies are accepted by the query originator. Guarded with #if defined(ZENOHCXX_ZENOHC) since it's zenoh-c only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update zenoh-c from a3071a12 to a3bf806e which includes the "stabilize accept replies (#1212)" change needed for the zenoh-cpp accept_replies stabilization task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…API guards Remove Z_FEATURE_UNSTABLE_API guards from ReplyKeyExpr typedef and accept_replies field/usage in GetOptions and QuerierOptions, keeping only ZENOHCXX_ZENOHC guards since the underlying zc_reply_keyexpr_t type is zenoh-c specific. Also remove @warning unstable and @note Zenoh-c only doc comments. Fixes eclipse-zenoh#745 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update zenoh-c from a3071a12 to a3bf806e which includes the "stabilize accept replies (#1212)" change needed for the zenoh-cpp accept_replies stabilization task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Include the new zc_query_accepts_replies() C API function from "add accept replies accessor to query (#1215)". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a new method to the C++ Query class that wraps zc_query_accepts_replies(), returning ReplyKeyExpr to indicate which replies are accepted by the query originator. Guarded with #if defined(ZENOHCXX_ZENOHC) since it's zenoh-c only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DenisBiryukov91
approved these changes
Mar 10, 2026
…ies' into zbobr_fix-44-stabilize-accept-replies
…ies' into zbobr_fix-44-stabilize-accept-replies
…accepts_replies API zenoh-c commit ee5125bb promoted the accepts_replies API from zc_ (internal) to z_ (stable) prefix. Update all C++ wrapper references accordingly: - enums.hxx: zc_reply_keyexpr_t -> z_reply_keyexpr_t, ZC_ -> Z_ enum values - query.hxx: zc_query_accepts_replies -> z_query_accepts_replies - session.hxx: zc_reply_keyexpr_default -> z_reply_keyexpr_default (2 places) - session_ext.hxx: zc_reply_keyexpr_default -> z_reply_keyexpr_default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…accepts_replies API zenoh-c commit ee5125bb promoted the accepts_replies API from zc_ (internal) to z_ (stable) prefix. Update all C++ wrapper references accordingly: - enums.hxx: zc_reply_keyexpr_t -> z_reply_keyexpr_t, ZC_ -> Z_ enum values - query.hxx: zc_query_accepts_replies -> z_query_accepts_replies - session.hxx: zc_reply_keyexpr_default -> z_reply_keyexpr_default (2 places) - session_ext.hxx: zc_reply_keyexpr_default -> z_reply_keyexpr_default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ies' into zbobr_fix-44-stabilize-accept-replies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #745
implemened with milyin-zenoh-zbobr/tasks#44