Merged
Conversation
Add stable accept_replies API to zenoh-java, matching the stabilized ReplyKeyExpr type from upstream zenoh PR #2443. Changes: - Create ReplyKeyExpr enum (MATCHING_QUERY, ANY) in Kotlin - Add acceptReplies field to GetOptions and QuerierOptions - Pass acceptReplies ordinal through JNI bridge (JNISession.kt) - Add decode_reply_key_expr in Rust utils.rs - Wire accept_replies into both getViaJNI and declareQuerierViaJNI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
PR missing one of the required labels: {'documentation', 'bug', 'new feature', 'internal', 'ci', 'enhancement', 'dependencies', 'breaking-change', 'api-sync'} |
9 tasks
yellowhatter
approved these changes
Mar 11, 2026
Pass accepts_replies from Rust Query through JNI to the Kotlin Query class, allowing queryable handlers to inspect what reply key expressions the querier accepts. Adds ReplyKeyExpr property to Query constructor, updates JNI callback signature, and adds test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove gradle wrapper files (gradle-wrapper.jar, gradle-wrapper.properties, gradlew, gradlew.bat) that were added unrelated to task - Delete Cargo.lock to use latest zenoh from main branch - Fix accepts_replies() call in session.rs: API now returns ReplyKeyExpr directly instead of Result<ReplyKeyExpr>, so remove .map_err(...)? chain Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yellowhatter
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #431
implemented in milyin-zenoh-zbobr/tasks#38