feat: add warning if drop-callback is passed with a tuple#366
Merged
Mallets merged 1 commit intoOct 18, 2024
Merged
Conversation
Contributor
|
PR missing one of the required labels: {'dependencies', 'breaking-change', 'internal', 'bug', 'enhancement', 'documentation', 'new feature'} |
Mallets
approved these changes
Oct 18, 2024
fuzzypixelz
reviewed
Oct 18, 2024
|
|
||
| const CHECK_SIGNALS_INTERVAL: Duration = Duration::from_millis(100); | ||
| const DONE_CALLBACK_WARNING: &str = "Passing drop-callback using a tuple \ | ||
| `(callback, drop-callback)` no more works in 1.0;\n\ |
Member
There was a problem hiding this comment.
Suggested change
| `(callback, drop-callback)` no more works in 1.0;\n\ | |
| `(callback, drop-callback)` no longer works in 1.0;\n\ |
| const DONE_CALLBACK_WARNING: &str = "Passing drop-callback using a tuple \ | ||
| `(callback, drop-callback)` no more works in 1.0;\n\ | ||
| `zenoh.handlers.Callback(callback, drop_callback)` must be used instead.\n\ | ||
| The tuple form is reserved for passing a handler with`(callback, handler)`.\n\ |
Member
There was a problem hiding this comment.
Suggested change
| The tuple form is reserved for passing a handler with`(callback, handler)`.\n\ | |
| The tuple form is reserved for passing a handler with `(callback, handler)`.\n\ |
| `zenoh.handlers.Callback(callback, drop_callback)` must be used instead.\n\ | ||
| The tuple form is reserved for passing a handler with`(callback, handler)`.\n\ | ||
| If you are already passing a handler but having this warning wrongly displayed, \ | ||
| you can silent it with:\n\ |
Member
There was a problem hiding this comment.
Suggested change
| you can silent it with:\n\ | |
| you can silence it with:\n\ |
| `(callback, drop-callback)` no more works in 1.0;\n\ | ||
| `zenoh.handlers.Callback(callback, drop_callback)` must be used instead.\n\ | ||
| The tuple form is reserved for passing a handler with`(callback, handler)`.\n\ | ||
| If you are already passing a handler but having this warning wrongly displayed, \ |
Member
There was a problem hiding this comment.
Suggested change
| If you are already passing a handler but having this warning wrongly displayed, \ | |
| If you are already passing a handler and this warning is still incorrectly displayed, \ |
wyfo
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364