Merged
Conversation
Align with upstream zenoh#2382: these QoS parameters on reply builders are deprecated because response QoS now automatically matches the original query's QoS to avoid priority inversion. - Add DeprecationWarning when congestion_control or priority is passed - Remove these params from build! macro calls (no longer forwarded) - Update .pyi stubs with .. deprecated:: notices Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9 tasks
diogomatsubara
suggested changes
Mar 5, 2026
Contributor
diogomatsubara
left a comment
There was a problem hiding this comment.
@milyin do you really want to commit the .zbobr changes? If not, then I think it can be added to .gitignore
Contributor
Author
No, I'll delete it manually here. In further updates it's deleted automatically. |
wyfo
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #688
implemented with milyin-zenoh-zbobr/tasks#28