Skip to content

deprecate reply options#689

Merged
milyin merged 3 commits intoeclipse-zenoh:mainfrom
milyin-zenoh-zbobr:zbobr_fix-28-deprecate-reply-options
Mar 6, 2026
Merged

deprecate reply options#689
milyin merged 3 commits intoeclipse-zenoh:mainfrom
milyin-zenoh-zbobr:zbobr_fix-28-deprecate-reply-options

Conversation

@milyin
Copy link
Contributor

@milyin milyin commented Mar 4, 2026

fix for #688
implemented with milyin-zenoh-zbobr/tasks#28

milyin and others added 2 commits March 4, 2026 21:38
Align with upstream zenoh#2382: these QoS parameters on reply builders
are deprecated because response QoS now automatically matches the
original query's QoS to avoid priority inversion.

- Add DeprecationWarning when congestion_control or priority is passed
- Remove these params from build! macro calls (no longer forwarded)
- Update .pyi stubs with .. deprecated:: notices

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@milyin milyin added the enhancement Existing things could work better label Mar 4, 2026
Copy link
Contributor

@diogomatsubara diogomatsubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milyin do you really want to commit the .zbobr changes? If not, then I think it can be added to .gitignore

@milyin
Copy link
Contributor Author

milyin commented Mar 5, 2026

@milyin do you really want to commit the .zbobr changes? If not, then I think it can be added to .gitignore

No, I'll delete it manually here. In further updates it's deleted automatically.
It should not be in the .gitignore - this is initial file for automatic PR creation, because github doesn't allow empty PRs

@milyin milyin merged commit 766a067 into eclipse-zenoh:main Mar 6, 2026
16 of 19 checks passed
@diogomatsubara diogomatsubara added this to the 1.8.0 milestone Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Existing things could work better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants