Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Expose the now-stable ReplyKeyExpr enum and accept_replies API from upstream zenoh PR #2443. This adds: - ReplyKeyExpr enum (Any, MatchingQuery) with DEFAULT classattr - Query.accepts_replies() method - Querier.accept_replies getter property - accept_replies parameter to Session.get() and Session.declare_querier() - ReplyKeyExpr registered in module exports - Updated type stubs and docstrings Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
PR missing one of the required labels: {'dependencies', 'internal', 'new feature', 'breaking-change', 'ci', 'bug', 'documentation', 'enhancement', 'api-sync'} |
9 tasks
wyfo
suggested changes
Mar 9, 2026
| """Accept replies whose key expressions match the query key expression.""" | ||
| ) | ||
|
|
||
| @final |
Contributor
There was a problem hiding this comment.
Whats the point of this code in a stub?
Contributor
Author
There was a problem hiding this comment.
It follows the pattern how documentation strigns are defined for other enum fields. As far as I remember, this is a way to document each enum variant individually
Contributor
There was a problem hiding this comment.
microsoft/python-language-server#1725 (comment)
But unrelated to the PR
wyfo
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #690
implemented with milyin-zenoh-zbobr/tasks#36