Selenium: Update the 'CreateFactoryTest' according to the test plan#10353

Merged

artaleks9 merged 8 commits intomasterfrom

Jul 11, 2018

Contributor

artaleks9 commented Jul 10, 2018

What does this PR do?

Rework and add test methods to the 'CreateFactoryTest' according to the test plan (https://docs.google.com/document/d/1HbU9rzto8wT-6CFE8GFPi3BEW60suVmSmxDkomqbxwQ/edit#heading=h.xa9oyfdrgazw)
Add and rework methods in the 'CreateFactoryPage' using the 'SeleniumWebDriverHelper'
Add and rework methods in the 'DashboardFactories'
Rework the 'selectResourceToUpload()' in the 'SeleniumWebDriverHelper' related to upload file to create factory on dashboard
Add the method 'getHttpsTransportUrl()' to the 'TestGitHubRepository'
Add the 'config-ws.json' file to the resources

What issues does this PR fix or reference?

artaleks9 added 6 commits

July 10, 2018 13:26


          Rework and add test methods to the 'CreateFactoryTest'

275621c


          Add and rework methods in the 'CreateFactoryPage' using the 'Selenium…

cee6a07

…WebDriverHelper'


          Add and rework methods in the 'DashboardFactories'

daecf0a


          Rework the 'selectResourceToUpload()' related to upload file to creat…

3e1bfea

…e factory on dashboard


          Add the method 'getHttpsTransportUrl()' to the 'TestGitHubRepository'

e7efa30


          Add the 'config-ws.json' file to the resources

5a19fef

artaleks9 added status/code-review kind/task team/che-qe labels

artaleks9 requested review from SkorikSergey and dmytro-ndp

July 10, 2018 11:24

artaleks9 requested a review from vparfonov as a code owner

July 10, 2018 11:24

Contributor Author

artaleks9 commented Jul 10, 2018

ci-test

dmytro-ndp reviewed

View reviewed changes

...src/main/java/org/eclipse/che/selenium/pageobject/dashboard/factories/CreateFactoryPage.java

-                public void waitGitUrlField() {
-                  redrawUiElementsTimeout.until(visibilityOfElementLocated(By.id(Locators.GIT_URL_ID)));
+                public void uploadSelectedConfigFile(Path resourcesUploadFile) throws IOException {

Contributor

dmytro-ndp Jul 10, 2018

It's better to have short note about why we should use hiddenUploadInputButton instead of regular uploadFileButton to make the code clear.

dmytro-ndp reviewed

View reviewed changes

...src/main/java/org/eclipse/che/selenium/pageobject/dashboard/factories/CreateFactoryPage.java Outdated

-                  searchWorkspaceField.sendKeys(text);
+                public void typeTextToSearchFactoryField(String expectedText) {
+                  seleniumWebDriverHelper.setValue(searchWorkspaceField, expectedText);
                   WaitUtils.sleepQuietly(1);

Contributor

dmytro-ndp Jul 10, 2018

Can we avoid sleeping here?

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

+                private static final String MINIMAL_TEMPLATE_FACTORY_NAME = generate("factoryMin", 4);
+                private static final String COMPLETE_TEMPLATE_FACTORY_NAME = generate("factoryComplete", 4);
+                private static final String FACTORY_CREATED_FROM_WORKSPACE_NAME = generate("factoryWs", 4);
+                private static final String FACTORY_CREATED_FROM_GIT = generate("factoryGit-", 4);

Contributor

dmytro-ndp Jul 10, 2018

FACTORY_CREATED_FROM_GIT > FACTORY_CREATED_FROM_GIT_NAME?

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

+                private static final String COMPLETE_TEMPLATE_FACTORY_NAME = generate("factoryComplete", 4);
+                private static final String FACTORY_CREATED_FROM_WORKSPACE_NAME = generate("factoryWs", 4);
+                private static final String FACTORY_CREATED_FROM_GIT = generate("factoryGit-", 4);
+                private static final String FACTORY_CREATED_FROM_CONFIG = generate("factoryConfig", 4);

Contributor

dmytro-ndp Jul 10, 2018

FACTORY_CREATED_FROM_CONFIG > FACTORY_CREATED_FROM_CONFIG_NAME?

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

+                private static final String FACTORY_CREATED_FROM_WORKSPACE_NAME = generate("factoryWs", 4);
+                private static final String FACTORY_CREATED_FROM_GIT = generate("factoryGit-", 4);
+                private static final String FACTORY_CREATED_FROM_CONFIG = generate("factoryConfig", 4);
+                private static final String FACTORY_CREATED_FROM_USER_JSON = generate("factoryUser", 4);

Contributor

dmytro-ndp Jul 10, 2018

FACTORY_CREATED_FROM_USER_JSON > FACTORY_CREATED_FROM_USER_JSON_NAME?

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

+                  workspaceServiceClient.delete(PROJECT_WS_NAME, defaultTestUser.getName());
+                  workspaceServiceClient.delete(NO_PROJECT_WS_NAME, defaultTestUser.getName());
+                  List<String> listFactory =

Contributor

dmytro-ndp Jul 10, 2018

listFactory > factoryList

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

                 @Test
-                public void shouldHandleIncorrectFactoryNames() {
+                public void checkHandlingOfNamesFactory() {

Contributor

dmytro-ndp Jul 10, 2018

checkHandlingOfNamesFactory > checkHandlingOfFactoryNames

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

                 }
+                @Test
+                public void checkEditorTemplateJson() throws Exception {

Contributor

dmytro-ndp Jul 10, 2018

checkEditorTemplateJson > checkEditorOfTemplateJson

dmytro-ndp reviewed

View reviewed changes

...um/che-selenium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateFactoryTest.java Outdated

+                }
                 @Test
                 public void shouldCreatingFactoryFromWorkspace() {

Contributor

dmytro-ndp Jul 10, 2018

shouldCreatingFactoryFromWorkspace > shouldCreateFactoryFromWorkspace

dmytro-ndp reviewed

View reviewed changes

selenium/che-selenium-test/src/test/resources/org/eclipse/che/selenium/dashboard/config-ws.json Outdated

+                    }
+                  }
+                }
+              }

                
                    No newline at end of file

Contributor

dmytro-ndp Jul 10, 2018

empty line at the end is missed

Contributor

riuvshin commented Jul 10, 2018

ci-test

eclipse-che deleted a comment from codenvy-ci


          Add corrections according to the review of the PR

4b465e0

dmytro-ndp reviewed

View reviewed changes

...src/main/java/org/eclipse/che/selenium/pageobject/dashboard/factories/CreateFactoryPage.java Outdated

+                  return seleniumWebDriverHelper.waitVisibilityAndGetEnableState(uploadFileButton);
                 }
+                // we have to use the hidden web-element, because the file is uploaded when we send the command to

Contributor

dmytro-ndp Jul 10, 2018

IMHO it's important to explain why we can't use uploadFileButtn directly, like the follow:
// we can't use 'uploadFileButton' element directly here because it is a DIV which just calls hidden input of file type 'hiddenUploadInputButton'


          Correct the comment to the 'uploadSelectedConfigFile()' according to …

9b347c8

…the last review

Contributor Author

artaleks9 commented Jul 10, 2018

ci-test

dmytro-ndp approved these changes

View reviewed changes

Contributor

riuvshin commented Jul 10, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10353
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey approved these changes

View reviewed changes

artaleks9 merged commit 7d3393a into master

artaleks9 deleted the che#9841 branch

July 11, 2018 07:29

benoitf removed the status/code-review label

benoitf added this to the 6.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels