CHE-11097: Add per-sidecar memory limit in WS.NEXT#11248
Merged
garagatyi merged 7 commits intoeclipse-che:masterfrom Sep 24, 2018
Merged
CHE-11097: Add per-sidecar memory limit in WS.NEXT#11248garagatyi merged 7 commits intoeclipse-che:masterfrom
garagatyi merged 7 commits intoeclipse-che:masterfrom
Conversation
Author
|
ci-build |
added 5 commits
September 18, 2018 12:13
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Simplify KubernetesPluginsToolingApplier by moving sidecar container configuration creation code to a separate component - K8sContainerResolver. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Simplify KubernetesPluginsToolingApplier by moving sidecar machine configuration creation code to a separate component - MachineResolver. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Simplify KubernetesPluginsToolingApplier by moving sidecar service discovery related code to a separate component - SidecarServicesProvisioner. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Add an ability to configure memory limit for a WS.NEXT sidecar in a sidecar configuration. If it is not configured in a sidecar it will be set using global default memory limit for sidecars. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
garagatyi
force-pushed
the
memoryfield
branch
from
b73eb5a to
e0d0428
Compare
benoitf
added
status/code-review
Author
|
ci-build |
added 2 commits
September 19, 2018 17:05
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Author
|
ci-build |
skabashnyuk
approved these changes
Sep 24, 2018
mshaposhnik
approved these changes
Sep 24, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor WS.NEXT sidecars k8s applier to simplify the code.
Add an ability to configure memory limit for a WS.NEXT sidecar in
a sidecar configuration. If it is not configured in a sidecar it
will be set using the global default memory limit for sidecars.
What issues does this PR fix or reference?
Related to #11097