CHE-11097: Allow setting sidecar memory limit in ws attributes#11323
Merged
garagatyi merged 1 commit intoeclipse-che:masterfrom Sep 24, 2018
Merged
CHE-11097: Allow setting sidecar memory limit in ws attributes#11323garagatyi merged 1 commit intoeclipse-che:masterfrom
garagatyi merged 1 commit intoeclipse-che:masterfrom
Conversation
Adding workspace config attribute "sidecar.<name of a sidecar from plugin definition>.memory_limit" overrides sidecar memory limit with the value of attribute converted to bytes number. Example: Attribute "sidecar-theia-ide-memory_limit": "300Mi" sets Theia ide sidecar container memory limit to 314572800 bytes. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
benoitf
added
status/code-review
skabashnyuk
approved these changes
Sep 24, 2018
mshaposhnik
approved these changes
Sep 24, 2018
Author
|
ci-build |
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding workspace config attribute
sidecar.<name of a sidecar from plugin definition>.memory_limitoverrides sidecar memory limit with the value of the attribute
converted to bytes number.
Example:
Attribute
sidecar.theia-ide.memory_limit": "300Misets Theia idesidecar container memory limit to 314572800 bytes.
What issues does this PR fix or reference?
Related to #11097
Release Notes
Docs PR