Skip to content

Issue #2218 - Windows Selector Bug#2335

Merged
joakime merged 1 commit into
jetty-9.4.xfrom
jetty-9.4.x-issue-2218-windows-livelock
Mar 15, 2018
Merged

Issue #2218 - Windows Selector Bug#2335
joakime merged 1 commit into
jetty-9.4.xfrom
jetty-9.4.x-issue-2218-windows-livelock

Conversation

@joakime

@joakime joakime commented Mar 14, 2018

Copy link
Copy Markdown
Contributor

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested review from gregw and sbordet March 14, 2018 23:19
LOG.debug("Selector {} waiting on select", selector);
int selected = selector.select();
if (selected == 0)
selected = selector.selectNow();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the key fix for the bug, identified during a conversation with @gregw and @sbordet

@joakime

joakime commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

@gregw do you want to see this merged in for the 9.4.9 respin?

@gregw gregw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakime joakime merged commit 358f324 into jetty-9.4.x Mar 15, 2018
@joakime joakime deleted the jetty-9.4.x-issue-2218-windows-livelock branch March 15, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants