Skip to content

Added DDRtest - #5137

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
Yuehan-Lin:ddr
Apr 5, 2019
Merged

Added DDRtest#5137
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
Yuehan-Lin:ddr

Conversation

@Yuehan-Lin

Copy link
Copy Markdown
Contributor

[ci skip]
Signed-off-by: Yuehan-Lin Yuehan.Lin@ibm.com

@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 2 times, most recently from 8b353c2 to 3d8aa3d Compare March 18, 2019 16:29
@llxia

llxia commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

jenkins test sanity win jdk8, jdk11

@llxia

llxia commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

jenkins test sanity win jdk8

@llxia

llxia commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

jenkins test sanity win jdk11

@llxia

llxia commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

jenkins test extended xlinux,plinux,aix,zlinux,xlinuxlargeheap jdk11

@llxia

llxia commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

jenkins test sanity win jdk11

@llxia

llxia commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

jenkins test extended xlinux,plinux,aix,zlinux,xlinuxlargeheap jdk11

Comment thread test/functional/DDR_Test/ddrSettings.mk Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/DDRExtTesterBase.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated
@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 41613cd to 059ab14 Compare March 21, 2019 15:22
@Yuehan-Lin

Copy link
Copy Markdown
Contributor Author

@keithc-ca please review, thank you!

Comment thread test/functional/DDR_Test/ddrSettings.mk Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
@llxia

llxia commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

DDR is supported on osx (PR #5127), please enable DDR tests on osx.

@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 2a35841 to 8228e0a Compare March 25, 2019 15:33
@Yuehan-Lin

Copy link
Copy Markdown
Contributor Author

@keithc-ca ready for review

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also address earlier feedback.

Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/corehelper/CoreGen.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/junit/TestSharedClassesExt.java Outdated
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 4 times, most recently from b18983a to beee5b9 Compare March 26, 2019 16:07
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
Comment thread test/functional/DDR_Test/playlist.xml Outdated
Comment thread test/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java Outdated
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
Comment thread test/functional/DDR_Test/tck_ddrext.xml Outdated
@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 3 times, most recently from aa8a8e5 to 9893a94 Compare April 3, 2019 15:18
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test extended aix,osx,plinux,xlinux,zlinux,win jdk8,jdk11

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the test needs some changes. It must load some extra classes not already in the shared class cache else this is to be expected:

     [java] [DDRExtTesterBase] [ERROR] '!walkinterntable  4' output does not contain success key : WALKING LOCAL INTERN HASHTABLE
     [java] [DDRExtTesterBase] [ERROR] '!walkinterntable  4' output :HeadNode is null

@Yuehan-Lin
Yuehan-Lin force-pushed the ddr branch 3 times, most recently from 6e8acf6 to fccbf74 Compare April 4, 2019 20:29
Fixed:eclipse-openj9#5095
[ci skip]
Signed-off-by: Yuehan-Lin <Yuehan.Lin@ibm.com>
@Yuehan-Lin

Copy link
Copy Markdown
Contributor Author

Last pr test failure is fixed, please review and test @keithc-ca

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test extended plinux jdk8,jdk11

Comment thread test/functional/DDR_Test/tck_ddrext.xml
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test extended aix,osx,xlinux,zlinux,win jdk8,jdk11

@keithc-ca

Copy link
Copy Markdown
Contributor

The AIX failure seems unrelated to this and more likely related to #3081.

@keithc-ca
keithc-ca merged commit 42712f7 into eclipse-openj9:master Apr 5, 2019
@llxia

llxia commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

@Yuehan-Lin Since runtimes/backlog/issues/124 is fixed, please re-enable zos in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants