Skip to content

Use config in MaterialIntegerControl #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Use config in MaterialIntegerControl #1422

merged 1 commit into from
Jul 3, 2019

Conversation

Lily418
Copy link
Contributor

@Lily418 Lily418 commented Jul 2, 2019

The config was not being passed to the MaterialInputControl in MaterialIntegerControl. This meant showUnfocusedDescription config was not being used.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.388% when pulling 0eb22ec on HelixCentre:feature/add-config-to-material-integer-control into d71437d on eclipsesource:master.

@edgarmueller edgarmueller self-requested a review July 3, 2019 08:05
edgarmueller
edgarmueller approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@edgarmueller edgarmueller merged commit d2eb8f1 into eclipsesource:master Jul 3, 2019
@Lily418 Lily418 deleted the feature/add-config-to-material-integer-control branch July 3, 2019 09:05
@sdirix sdirix changed the title Add config to MaterialIntegerControl Use config in MaterialIntegerControl Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edgarmueller edgarmueller edgarmueller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lily418 @coveralls @edgarmueller