Remove registerStartupRenderer and replace with explicit initialization #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
previously requested changes
Feb 9, 2018
Member
eneufeld
left a comment
eneufeld
left a comment
There was a problem hiding this comment.
Looks good. I like the removal of the static field.
As discussed please move the renderers and fields to the init action to force the user to provide renderers and fields
Remove JsonFormsInit Re-order dependencies in material renderer set
edgarmueller
force-pushed
the
topic/remove-startup-registration
branch
from
37c91e0 to
e2ecd09
Compare
Contributor
Author
|
@eneufeld this should be fine now, can you approve? |
AlexandraBuzila
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectToJsonFormsconsistently, make 'react-redux` import obsoletereact-reduxdependency a dev dependency in renderer sets and remove react-dom dependency from material renderer set