add data prop and rerender FAQ #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
reviewed
Dec 19, 2023
content/faq/faq.mdx
Outdated
Comment on lines
123
to
124
| Like most React components, JSON Forms will revalidate and rerender whenever a new object is passed to it. | ||
| To reduce unnecessary rerenders and optimize your application's performance, any prop handed over to JsonForms in React should be either stable or memoized. |
Member
There was a problem hiding this comment.
We should elaborate a bit here:
- JSON Forms uses React.memo, so to avoid any unnecessary rerenderings only stable properties should be handed over
Some specifics:
- Handing over a new
schemaprop will revalidate and rerender - Handing over a new
dataprop will revalidate and rerender, except for if it's thedatawhich was emitted byonChange - Handing over a new
onChangeis fine as neitherrerendernorrevalidatewill be triggers - Handing over a new
i18nis fine, as long as the properties are stable. - validationMode change might trigger a revalidation and rerender
- Handing over anything else new will potentially lead to a
rerender.
LukasBoll
force-pushed
the
rerender_faq
branch
from
d82166c to
62e13c8
Compare
closes eclipsesource#214 Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
sdirix
requested changes
Mar 20, 2024
sdirix
requested changes
Mar 20, 2024
sdirix
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #214