Fix the issue where document.getWordRangeAtPosition() returns incorre… #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct positions due to changes in the document before the results from getStyles() are returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where
document.getWordRangeAtPosition()retrieves incorrect positions due to inputting other content before the results fromgetStyles()are returned.This can fix the issue where quickly typing a class name causes the completion to incorrectly overwrite content outside of the class attribute. For example:
Expected result:
<h class="test100"></h>Actual result:
<h class=" test100></h><h class=" test100</h>This situation becomes particularly noticeable when
editor.quickSuggestions.stringis enabled. The faster you type or the larger the css file, the more characters are overwritten.This fix can resolve issue #278.
You can reproduce the issue using the files in this zip archive.
html-class-test.zip