Skip to content

[1440] update config_zarr2cf.yaml#1441

Merged
tjhunter merged 5 commits intoecmwf:mainfrom
enssow:sorcha/dev/1440
Dec 10, 2025
Merged

[1440] update config_zarr2cf.yaml#1441
tjhunter merged 5 commits intoecmwf:mainfrom
enssow:sorcha/dev/1440

Conversation

@enssow
Copy link
Contributor

@enssow enssow commented Dec 9, 2025

Description

Updates config so uv run export executes correctly

Issue Number

Closes #1440
Fixes #1440

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Copy link
Collaborator

@iluise iluise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. maybe before merging can you just revert the changes not related to the PR? three files got updated but it is just some linter minor changes. I also noticed that issues are not linked automatically on the main branch @tjhunter

@tjhunter tjhunter linked an issue Dec 10, 2025 that may be closed by this pull request
@tjhunter
Copy link
Collaborator

It seems you need to set the manually in the github UI for the time being on main. Given how often we do that, I do not believe we need to update the scripts.

@tjhunter tjhunter merged commit a6e07a4 into ecmwf:main Dec 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

uv run export on main using old config

3 participants