change source interval in the export package#2265
Merged
Merged
Conversation
enssow
approved these changes
Apr 27, 2026
Contributor
enssow
left a comment
There was a problem hiding this comment.
Tested with both netcdf and verif parser using id=cae70ju8; s=ERA5; uv run export --run-id $id --stream $s --output-dir ../${id}_${s} --format verif --obs ../metno_observations_v3.nc and id=cae70ju8; s=ERA5; uv run export --run-id $id --stream $s --output-dir ../${id} --format netcdf on SANTIS; both produced expected results
wael-mika
pushed a commit
to wael-mika/WeatherGenerator
that referenced
this pull request
May 3, 2026
* change source interval * fix chunking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implement a more solid way to retrieve the forecast steps that takes into account also the substeps.
Where
source_endis the last valid_time of thesourcewindow.example:
steps:
Issue Number
Closes #2264
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60