Skip to content

Fixed ruff error#460

Closed
clessig wants to merge 1 commit intodevelopfrom
clessig/develop/fix_ruff_459
Closed

Fixed ruff error#460
clessig wants to merge 1 commit intodevelopfrom
clessig/develop/fix_ruff_459

Conversation

@clessig
Copy link
Copy Markdown
Collaborator

@clessig clessig commented Jul 7, 2025

Description

Fix ruff

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Closes #459

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I ran the uv run train and (if necessary) uv run evaluate on a least one GPU node and it works
  • If the new feature introduces modifications at the config level, I have made sure to have notified the other software developers through Mattermost and updated the paths in the $WEATHER_GENERATOR_PRIVATE directory

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@clessig clessig requested a review from tjhunter July 7, 2025 11:03
@clessig clessig closed this Jul 7, 2025
@tjhunter
Copy link
Copy Markdown
Collaborator

tjhunter commented Jul 7, 2025

@clessig I would like to close this branch in favor of #463 . If you agree, would you mind closing this PR?

@clessig
Copy link
Copy Markdown
Collaborator Author

clessig commented Jul 7, 2025

@clessig I would like to close this branch in favor of #463 . If you agree, would you mind closing this PR?

Was long closed ;)

@clessig clessig deleted the clessig/develop/fix_ruff_459 branch July 7, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix formatting

2 participants