Skip to content

Conversation

@AlexandreMary
Copy link
Contributor

Description

To cope with the issue described in Issue #39, has been implemented the following:

For each git project of the bundle:

  • when the remote name is not provided in the bundle, if the repository exists, the registered remotes are explored:
  • if a registered remote has the same url as the requested url, its remote name is used
  • if no registered remote has the same url, it is added, with a remote name generated uniquely from the url
  • the unicity is ensured by hashing the url; it is not very readable, open to any better idea.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.66%. Comparing base (55c2ec4) to head (6bdfc71).

Files with missing lines Patch % Lines
ecbundle/download.py 88.88% 2 Missing ⚠️
ecbundle/git.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
+ Coverage    40.55%   40.66%   +0.11%     
===========================================
  Files           49       49              
  Lines        10133    10156      +23     
===========================================
+ Hits          4109     4130      +21     
- Misses        6024     6026       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdeconinck
Copy link
Member

Thank you for creating this PR @AlexandreMary; I don't see any issue with this. I only fixed the failed QA code test used with automated tools "isort", "black", "flake8".
So good to merge!

@wdeconinck wdeconinck merged commit 9d4fa6d into ecmwf:develop Jan 28, 2026
4 checks passed
@AlexandreMary
Copy link
Contributor Author

Thanks
Do you plan any release soon ?
The last one is one year old, and I'd like to have this included for our CY50T2.

wdeconinck added a commit that referenced this pull request Jan 28, 2026
* release/2.4.0:
  Version 2.4.0
  Manage multi-remotes (#40)
  Fix QA code due to updated black
  Add genesis information to configure.sh script as per issue #32 (#38)
  Fix printing of version in the generated configure/build/install scripts (#37)
  Only raise symlink failure error if target exists (#35)
  Revert to absolute symlinks if relative link generation fails (#30)
@wdeconinck
Copy link
Member

Now part of ecbundle 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants