ECC-2222: Add model keyword for indexing of DestinE On-demand-extremes-dt (DE330) data#434
Merged
joobog merged 6 commits intohotfix/2.46.1from Mar 16, 2026
Merged
Conversation
… bit more testing to confirm.
… done post metadata otherwise the metadata for the modelName is not yet defined as they come in Section 4. Thus we use logic in post_meta_data.hook for productionstatus 12/13. I also take this opportunity to refactor that into includes to prevent duplicated code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hotfix/2.46.1 #434 +/- ##
================================================
Coverage ? 88.51%
================================================
Files ? 849
Lines ? 63104
Branches ? 11226
================================================
Hits ? 55856
Misses ? 7248
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mjg41
changed the title
joobog
approved these changes
Mar 16, 2026
Collaborator
joobog
left a comment
joobog
left a comment
There was a problem hiding this comment.
Looks good, implemented as discussed.
joobog
pushed a commit
that referenced
this pull request
Mar 16, 2026
…s-dt (DE330) data (#434) * ECC-2222: First try * ECC-2222: Approach suggested by Eugen, which looks good. Want to do a bit more testing to confirm. * ECC-2222: Concept and aliasing into mars namespace must ultimately be done post metadata otherwise the metadata for the modelName is not yet defined as they come in Section 4. Thus we use logic in post_meta_data.hook for productionstatus 12/13. I also take this opportunity to refactor that into includes to prevent duplicated code. * ECC-2222: Newline suggested by copilot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The on-demand-extremes-dt routinely runs multiple models covering the same period, such as different NWP models (ALARO, AROME, HARMONIE-AROME) as well as several impact models (AQ, Hydrology, renewables, wildfire etc.).
Thus it makes sense to introduce the model keyword introduced in other datasets such as class=ai and the new hydrology data layout also to on-demand-extremes data. We will add the model keyword in the same way here.
ADR approved, to be merged at: ecmwf/codex#40
Contributor Declaration
By opening this pull request, I affirm the following: