Enforce minimum cmake version also in python wheel download macro#75
Merged
Merged
Conversation
Contributor
Author
|
Hi @wdeconinck could you please review? Thanks! |
Member
|
Raising the cmake minimum required may need coordination with @iainrussell . |
awnawab
force-pushed
the
bugfix/find_package_python3
branch
from
1adf07e to
63a3357
Compare
awnawab
changed the title
Contributor
Author
|
It turns out that simply enforcing a minimum cmake version of 3.17 is also enough to fix the find_python behaviour this PR is addressing, so I've rolled it the minimum cmake version back to 3.17 as before. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #75 +/- ##
========================================
Coverage 51.35% 51.35%
========================================
Files 58 58
Lines 4812 4812
Branches 449 449
========================================
Hits 2471 2471
Misses 2341 2341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wdeconinck
added a commit
that referenced
this pull request
Feb 23, 2026
* hotfix/0.14.2: Version 0.14.2 Replace use of deprecated Library::lookup (#84) Add fortran linker flag submitted by AMD for AOCC (and Classic Flang) (#82) Workaround for failing fckit_test_shared_ptr with aocc/nvhpc/intel by detecting compiler bugs (#80) FCKIT_VENV_INSTALL: add a new ecbuild feature to control the (#78) Add miniumum cmake version check in wheel download macro (#75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small PR that raises the minimum cmake version to 3.19 and also enforces the minimum for the populate workflow. This is needed to ensure the correct python interpreter after a system update in the Atos which installed python3.12.