fix test set properties (with FDB_BUILD_TOOLS disabled)#232
Merged
Conversation
Ozaq
reviewed
Feb 24, 2026
tests/fdb/tools/wipe/CMakeLists.txt
Outdated
Comment on lines
23
to
25
| if (TARGET test_fdb_tools_wipe_${_test}) | ||
| set_tests_properties(test_fdb_tools_wipe_${_test} PROPERTIES RESOURCE_LOCK fdb_tools_wipe_lock) | ||
| endif() |
Member
There was a problem hiding this comment.
Dumb question, but ecbuild_add_test supports PROPERTIES and TEST_PROPERTIES, why not just add the LOCK in the call with condition above?
Member
Author
There was a problem hiding this comment.
Initially I tried setting PROPERTIES inside ecbuild_add_test:
ecbuild_add_test(
TARGET test_fdb_tools_wipe_${_test}
...
PROPERTIES
RESOURCE_LOCK fdb_tools_wipe_lock
)
getting the following error:
CMake Error at /usr/local/share/ecbuild/cmake/ecbuild_add_test.cmake:475 (set_target_properties):
set_target_properties Can not find target to add properties to:
test_fdb_tools_wipe_shared_root
Call Stack (most recent call first):
fdb5/tests/fdb/tools/wipe/CMakeLists.txt:13 (ecbuild_add_test)
But you are right @Ozaq, TEST_PROPERTIES seems to works well
Member
There was a problem hiding this comment.
I just saw it in the doc, thanks for trying it out :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #232 +/- ##
========================================
Coverage 74.02% 74.03%
========================================
Files 376 376
Lines 23738 23738
Branches 2469 2471 +2
========================================
+ Hits 17572 17574 +2
+ Misses 6166 6164 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ozaq
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-232
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-232