Skip to content

FORK: FDB 649 improve support for optional + default#255

Merged
danovaro merged 2 commits intofeature/optional-defaultfrom
feature/optional-default-fork
Mar 26, 2026
Merged

FORK: FDB 649 improve support for optional + default#255
danovaro merged 2 commits intofeature/optional-defaultfrom
feature/optional-default-fork

Conversation

@mcakircali
Copy link
Copy Markdown
Contributor

@mcakircali mcakircali commented Mar 23, 2026

Description

Alternative implementation of "optional-default" work

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-255

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (95f9677) to head (465cd07).

Files with missing lines Patch % Lines
src/fdb5/rules/Matcher.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/optional-default     #255      +/-   ##
============================================================
+ Coverage                     71.23%   71.32%   +0.09%     
============================================================
  Files                           376      376              
  Lines                         23789    23791       +2     
  Branches                       2488     2483       -5     
============================================================
+ Hits                          16946    16970      +24     
+ Misses                         6843     6821      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcakircali mcakircali requested a review from danovaro March 23, 2026 07:45
@danovaro danovaro merged commit 73a7640 into feature/optional-default Mar 26, 2026
333 of 363 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants