Skip to content

Set date/time in StageRuntime instead of Preset#191

Merged
dsarmany merged 2 commits intodevelopfrom
feature/mars2grib-cache-datetime
Apr 15, 2026
Merged

Set date/time in StageRuntime instead of Preset#191
dsarmany merged 2 commits intodevelopfrom
feature/mars2grib-cache-datetime

Conversation

@pgeier
Copy link
Copy Markdown
Contributor

@pgeier pgeier commented Apr 2, 2026

Description

The mars2grib encoder currently sets date and time once in the preset stage. For climate-dt monthly means will produce increasing date/time. To efficiently reuse previously cached grib2 handles, the date/time must be set in the latest stage (runtime).

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.99%. Comparing base (4134d2f) to head (8bdc834).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #191   +/-   ##
========================================
  Coverage    61.99%   61.99%           
========================================
  Files          303      303           
  Lines        11663    11663           
  Branches      1048     1048           
========================================
  Hits          7231     7231           
  Misses        4432     4432           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MircoValentiniECMWF
Copy link
Copy Markdown
Contributor

There are several ways to achieve this result. The appropriate solution should be decided based on tests involving the other affected projects, as I noted in the Teams chat.

@MircoValentiniECMWF
Copy link
Copy Markdown
Contributor

Benchmarks confirmed that safe cache is too slow to be taken into consideration as a possible candidate.

@pgeier pgeier force-pushed the feature/mars2grib-cache-datetime branch from ed76f11 to bae37af Compare April 13, 2026 07:24
@dsarmany dsarmany force-pushed the feature/mars2grib-cache-datetime branch from bae37af to 8bdc834 Compare April 15, 2026 07:34
@dsarmany dsarmany merged commit a9e3e2a into develop Apr 15, 2026
113 checks passed
@dsarmany dsarmany deleted the feature/mars2grib-cache-datetime branch April 15, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants